dialects: (hw) Add visibility keyword to hw.module #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I thought GitHub would be smarter about showing changes. Some of the changes are from #2507. |
Moxinilian
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
==========================================
+ Coverage 89.78% 89.81% +0.02%
==========================================
Files 350 351 +1
Lines 43284 43623 +339
Branches 6461 6512 +51
==========================================
+ Hits 38863 39178 +315
- Misses 3462 3486 +24
Partials 959 959 ☔ View full report in Codecov by Sentry. |
Moxinilian
force-pushed
the
hw-module-visibility
branch
from
fdc238c to
e647377
Compare
lucjaulmes
approved these changes
Apr 26, 2024
Moxinilian
force-pushed
the
hw-module-visibility
branch
from
2cf8e46 to
8cd2666
Compare
PapyChacal
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2507