dialects: (x86) PR13 - M Operations #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure how to tackle the M version of the 'pop' operation. Since it only has a destination that is a memory access, there is no registers involved other than RSP. Where would the information of what the memory access should be come from in the IR? I can only think of something like; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
- Coverage 89.83% 89.81% -0.02%
==========================================
Files 351 351
Lines 44027 44095 +68
Branches 6574 6589 +15
==========================================
+ Hits 39552 39606 +54
- Misses 3516 3528 +12
- Partials 959 961 +2 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
May 3, 2024
Comment on lines
+1231
to
+1240
| source = _assembly_arg_str(self.source) | ||
| if self.offset is not None: | ||
| offset = _assembly_arg_str(self.offset) | ||
| if self.offset.value.data > 0: | ||
| source = f"[{source}+{offset}]" | ||
| else: | ||
| source = f"[{source}{offset}]" | ||
| else: | ||
| source = f"[{source}]" | ||
| return (source,) |
There was a problem hiding this comment.
this is starting to look like a good opportunity for a helper :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some operations taking only one memory access as operand. I decided to make 'push' into its own function as opposed to the way I did it with the register version as I don't think there's any other method that would inherit from that. I will probably reformat the register version as well in a PR later.