core: add argument and result types getters to CallableOpInterface #2535
Conversation
superlopuh
requested review from
compor,
AntonLydike,
georgebisbas,
JosseVanDelm,
PapyChacal,
Moxinilian and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sasha/memref/malloc-riscv #2535 +/- ##
==========================================================
Coverage 89.82% 89.82%
==========================================================
Files 351 352 +1
Lines 44116 44169 +53
Branches 6593 6593
==========================================================
+ Hits 39625 39674 +49
- Misses 3531 3535 +4
Partials 960 960 ☔ View full report in Codecov by Sentry. |
Codecov ReportThis pull request has no tests Mr Lopoukhine.
Additional details and impacted filesactually no thanks ☔ View full report in Codecov by Théo |
|
Weird indeed, I was aware that there were no tests but the fact that CodeCov doesn't bring this up is somewhat surprising. I'll add some |
| raise NotImplementedError() | ||
|
|
||
| @classmethod | ||
| @abc.abstractmethod | ||
| def get_argument_types(cls, op: Operation) -> tuple[Attribute, ...]: | ||
| raise NotImplementedError() | ||
|
|
||
| @classmethod | ||
| @abc.abstractmethod | ||
| def get_result_types(cls, op: Operation) -> tuple[Attribute, ...]: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
Is there a reference you can give to the MLIR equivalent?
There was a problem hiding this comment.
I tried to hunt for this, but the best one I found was at the link in the docstring for the whole trait. I also found it quite difficult to navigate the tablegen.
This adds some more of the capabilities of the MLIR equivalent.
Note stacked PR