Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (x86) PR16 - Conditional Jumps #2552

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

KGrykiel
Copy link
Collaborator

@KGrykiel KGrykiel commented May 9, 2024

I added conditional jumps and some infrastructure around it such as the RFLAGS register as well as the 'cmp' operation. For completeness I implemented almost all of the different conditional branch instructions even though some of them are functionally identical. i didn't test all of them individually because they're all the same in essence, but let me know if I should anyway.

@KGrykiel KGrykiel added the dialects Changes on the dialects label May 9, 2024
@KGrykiel KGrykiel self-assigned this May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (1a36998) to head (964933b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   89.81%   89.79%   -0.02%     
==========================================
  Files         354      354              
  Lines       44356    44579     +223     
  Branches     6624     6684      +60     
==========================================
+ Hits        39838    40030     +192     
- Misses       3551     3574      +23     
- Partials      967      975       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might as well add the tests, so we can detect regressions if there are any in the future. Hopefully it won't be too annoying if you write a little Python script to generate the lit test

@KGrykiel KGrykiel requested a review from superlopuh May 9, 2024 16:55
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KGrykiel KGrykiel merged commit 4bfe7a3 into main May 10, 2024
10 checks passed
@KGrykiel KGrykiel deleted the KGrykiel/x86dialect-PRs16 branch May 10, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants