Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix line numbers in split input mode. #2563

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented May 12, 2024

I think the effect it is self-explanatory in the one changed test!.

@PapyChacal PapyChacal added enhancement New feature or request core xDSL core (ir, textual format, ...) labels May 12, 2024
@PapyChacal PapyChacal self-assigned this May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (59386fe) to head (93863ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2563   +/-   ##
=======================================
  Coverage   89.75%   89.76%           
=======================================
  Files         354      354           
  Lines       44741    44749    +8     
  Branches     6712     6714    +2     
=======================================
+ Hits        40159    40167    +8     
  Misses       3601     3601           
  Partials      981      981           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review May 12, 2024 13:41
xdsl/utils/lexer.py Outdated Show resolved Hide resolved
@PapyChacal PapyChacal merged commit 0c0ac43 into main May 13, 2024
9 checks passed
@PapyChacal PapyChacal deleted the emilien/split-line-number branch May 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants