testing: no more inout parameters in bottom-up test #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sasha/snitch/no-dense #2565 +/- ##
=========================================================
- Coverage 89.75% 89.74% -0.01%
=========================================================
Files 354 354
Lines 44750 44750
Branches 6714 6714
=========================================================
- Hits 40165 40163 -2
- Misses 3603 3605 +2
Partials 982 982 ☔ View full report in Codecov by Sentry. |
superlopuh
force-pushed
the
sasha/snitch/no-inout-again
branch
from
32b2396 to
8375bdd
Compare
superlopuh
commented
May 12, 2024
| // CHECK-NEXT: mv t3, a0 | ||
| // CHECK-NEXT: mv t1, a1 | ||
| // CHECK-NEXT: li t4, -1060927488 | ||
| // CHECK-NEXT: sw t4, -4(sp) |
There was a problem hiding this comment.
this is the only bit that I haven't tested, but it should be ok
There was a problem hiding this comment.
Should be fine, we don't really respect the stack much anyway right now 😄
lol 😄 |
AntonLydike
approved these changes
May 13, 2024
| // CHECK-NEXT: mv t3, a0 | ||
| // CHECK-NEXT: mv t1, a1 | ||
| // CHECK-NEXT: li t4, -1060927488 | ||
| // CHECK-NEXT: sw t4, -4(sp) |
There was a problem hiding this comment.
Should be fine, we don't really respect the stack much anyway right now 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bit will make it easier to raise to memref and scf, the last non-riscv bits.
I visually compared these to the new kernels' assembly in the epxeriments repo, and they look pretty much the same.