interpreter: (riscv) add fmv.d implementation #2571
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
=======================================
Coverage ? 89.65%
=======================================
Files ? 357
Lines ? 45173
Branches ? 6791
=======================================
Hits ? 40498
Misses ? 3655
Partials ? 1020 ☔ View full report in Codecov by Sentry. |
|
Not an expert, but my understanding of this instruction is that it will cast from a float encoded as an int to a float. Is this properly handled here? (I don't know the interpreter infra) |
|
This just moves a float to a float, the int casting op is fcvt.w.s. |
| args: tuple[Any, ...], | ||
| ): | ||
| args = RiscvFunctions.get_reg_values(interpreter, op.operands, args) | ||
| results = args |
There was a problem hiding this comment.
I think you could get away without this line?
There was a problem hiding this comment.
Defo, I'm just trying to make it explicit what's happening here, I feel like it makes it a bit clearer that it's on purpose. Maybe it could be resolved better with a comment...
No description provided.