Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add irdl.base #2581

Merged
merged 2 commits into from
May 15, 2024
Merged

core: Add irdl.base #2581

merged 2 commits into from
May 15, 2024

Conversation

math-fehr
Copy link
Collaborator

Add irdl.base to IRDL, which is equivalent to our `BaseConstraint.

@math-fehr math-fehr added the dialects Changes on the dialects label May 13, 2024
@math-fehr math-fehr self-assigned this May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (0c0ac43) to head (ea26c2c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
- Coverage   89.74%   89.64%   -0.10%     
==========================================
  Files         356      357       +1     
  Lines       44796    45232     +436     
  Branches     6721     6801      +80     
==========================================
+ Hits        40201    40548     +347     
- Misses       3609     3659      +50     
- Partials      986     1025      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@math-fehr math-fehr merged commit 6e287ca into main May 15, 2024
10 checks passed
@math-fehr math-fehr deleted the fehr/load-irdl-file branch May 15, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants