transformations: fix memref_streamify non idempotency and wrong maps for outs #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 358 358
Lines 45359 45361 +2
Branches 6827 6828 +1
=======================================
+ Hits 40663 40665 +2
Misses 3665 3665
Partials 1031 1031 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
May 15, 2024
| @@ -1,5 +1,9 @@ | |||
| // RUN: xdsl-opt -p memref-streamify %s | filecheck %s | |||
|
|
|||
| // Check that streamfying twice does not make further changes | |||
| // RUN: xdsl-opt -p memref-streamify,memref-streamify %s | filecheck %s | |||
There was a problem hiding this comment.
This is a very neat idea! I like adding these kinds of things to tests!
There was a problem hiding this comment.
idempotency is a pre-requisite for our exhaustive search of IRs not to explode BTW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.