Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (csl) Adding Constructors for comptime_struct and color, as well as some layout functions. #2612

Merged
merged 7 commits into from
May 21, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented May 20, 2024

This PR adds:

  • csl.const_struct
    • comptime_struct literal constructor
  • csl.get_color
    • Corresponds to @get_color in CSL
  • csl.set_rectangle
    • Corresponds to @set_rectangle in CSL
  • csl.set_tile_code
    • Corresponds to @set_tile_code in CSL

@dk949 dk949 added the dialects Changes on the dialects label May 20, 2024
@dk949 dk949 requested review from superlopuh, AntonLydike and n-io May 20, 2024 16:22
@dk949 dk949 self-assigned this May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (e20623b) to head (f74d79b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
- Coverage   89.62%   89.62%   -0.01%     
==========================================
  Files         358      358              
  Lines       45642    45676      +34     
  Branches     6881     6888       +7     
==========================================
+ Hits        40905    40935      +30     
- Misses       3685     3687       +2     
- Partials     1052     1054       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! I guess nested const structs require the creation of multiple structs and feeding their SSA values into the next const struct?

Anyway, good stuff!

@AntonLydike AntonLydike merged commit 6252a84 into main May 21, 2024
10 checks passed
@AntonLydike AntonLydike deleted the david/csl-dialect/simple-ops branch May 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants