-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Make printer scoped. #2614
Conversation
Thank you so much for this 👏 👏 👏 |
I'm gonna take a shot at the failing tests that I know about |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 89.58% 89.58%
=======================================
Files 360 360
Lines 45959 45974 +15
Branches 6954 6960 +6
=======================================
+ Hits 41171 41186 +15
Misses 3717 3717
Partials 1071 1071 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool!
Fixes #2609
See https://xdsl.zulipchat.com/#narrow/stream/364199-Beginners/topic/SSA.20Value.20name.20re-use.20is.20broken : please, come in and enjoy updating the filechecks 😉
This will indeed make future works less tedious!
On the changes:
enter_scope
andexit_scope
, simply pushing and popping on those stacks. So it's usable in different places if somebody wants to have fun in custom syntax? We can make those private first I guessPrinter.print_op
, after the results are printed!) to scope if the printed op happens to be IsolatedFromAbove