dialects: (csl) Added operations to manage symbols #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
- Coverage 89.62% 89.56% -0.06%
==========================================
Files 358 358
Lines 45676 45782 +106
Branches 6888 6920 +32
==========================================
+ Hits 40935 41004 +69
- Misses 3687 3712 +25
- Partials 1054 1066 +12 ☔ View full report in Codecov by Sentry. |
AntonLydike
reviewed
May 22, 2024
xdsl/dialects/csl.py
Outdated
Comment on lines
718
to
733
| def _verify_memref_addr(self, val_ty: MemRefType[Attribute], res_ty: PtrType): | ||
| res_elem_ty = res_ty.get_element_type() | ||
| if res_elem_ty == val_ty.get_element_type(): | ||
| if res_ty.kind.data != PtrKind.MANY: | ||
| raise VerifyException( | ||
| f"The kind of scalar pointer to array has to be {PtrKind.MANY.value}" | ||
| ) | ||
| elif res_elem_ty == val_ty: | ||
| if res_ty.kind.data != PtrKind.SINGLE: | ||
| raise VerifyException( | ||
| f"The kind of array pointer to array has to be {PtrKind.SINGLE.value}" | ||
| ) | ||
| else: | ||
| raise VerifyException( | ||
| "Contained type of the result pointer must match the contained type of the operand memref or the memref itself" | ||
| ) |
There was a problem hiding this comment.
Can you add a docstring to this method? It seems to be quite complex
AntonLydike
reviewed
May 22, 2024
| %other_global_ptr = "test.op"() : () -> !csl.ptr<i16, #csl<ptr_kind single>, #csl<ptr_const var>> | ||
|
|
||
| "csl.export"() <{var_name = @initialize, type = () -> ()}> : () -> () | ||
| "csl.export"() <{var_name = @global_ptr, type = !csl.ptr<f32, #csl<ptr_kind many>, #csl<ptr_const const>>}> : () -> () |
There was a problem hiding this comment.
Where is @global_ptr? I think we should only allow function exporting using symbols, or do we have an op to "bind" a value to a symbol?
There was a problem hiding this comment.
I assumed it's possible to declare a global pointer like that in MLIR, but it would make more sense to limit symbols to just function types.
When passing name as string with SSA operand, only pointer types can be used. When passing a symbol ref, only function types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
csl.addressofcsl.export)csl.exportcsl.rpc@rpcin the language@rpcwas going away in SDK 1.1, but now I can't find a reference to it in the documentation.csl.param