backend: (riscv) Allocate ub and step before loop, and lb after #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
=======================================
Coverage 89.62% 89.62%
=======================================
Files 358 358
Lines 45676 45678 +2
Branches 6888 6887 -1
=======================================
+ Hits 40935 40937 +2
Misses 3687 3687
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
AntonLydike
changed the title
superlopuh
commented
May 22, 2024
| @@ -29,18 +29,18 @@ riscv_func.func @main() { | |||
| // CHECK-LIVENESS-BLOCK-NAIVE: builtin.module { | |||
| // CHECK-LIVENESS-BLOCK-NAIVE-NEXT: riscv_func.func @external() -> () | |||
| // CHECK-LIVENESS-BLOCK-NAIVE-NEXT: riscv_func.func @main() { | |||
| // CHECK-LIVENESS-BLOCK-NAIVE-NEXT: %{{.+}} = riscv.li 0 : () -> !riscv.reg<zero> | |||
There was a problem hiding this comment.
I think the anonymous ssa value here actually makes it harder to read the test
AntonLydike
approved these changes
May 24, 2024
zero9178
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of two PRs fixing our register allocator, this one allows for reuse of the iteration argument, which is currently never freed.