Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: CSE: Refactor for reuse-friendliness #2642

Merged
merged 1 commit into from
May 25, 2024

Conversation

PapyChacal
Copy link
Collaborator

Refactor CSEDrive to make most things private and mostly expose simplify, applying CSE on one Operation/Block/Region.
Then just expose a public cse function as entry-point: any rewrite can now just import cse and use it during other transformation 🙂

@PapyChacal PapyChacal added the transformations Changes or adds a transformatio label May 24, 2024
@PapyChacal PapyChacal self-assigned this May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (20707cb) to head (6a3d660).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   89.58%   89.58%   -0.01%     
==========================================
  Files         360      360              
  Lines       46005    46020      +15     
  Branches     6964     6966       +2     
==========================================
+ Hits        41215    41225      +10     
- Misses       3718     3722       +4     
- Partials     1072     1073       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review May 24, 2024 16:26
@PapyChacal PapyChacal merged commit 24c4a71 into main May 25, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/cse-api branch May 25, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants