Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv_func) mark riscv_func.func as isolated from above #2669

Merged
merged 3 commits into from
May 31, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented May 30, 2024

Mostly filecheck ssa name changes again, had to move a few values around, found one "bug" in an assembly printing test.

@superlopuh superlopuh added the dialects Changes on the dialects label May 30, 2024
@superlopuh superlopuh self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.65%. Comparing base (06ea7da) to head (87fb41b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2669   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         364      364           
  Lines       46585    46585           
  Branches     7038     7038           
=======================================
  Hits        41765    41765           
  Misses       3733     3733           
  Partials     1087     1087           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Base automatically changed from sasha/riscv/isolated-from-above to main May 31, 2024 10:30
@superlopuh superlopuh merged commit 4a6e6ff into main May 31, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/riscv/func-isolated-from-above branch May 31, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants