Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialects: (csl) adding dsd ops #2674

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Dialects: (csl) adding dsd ops #2674

merged 4 commits into from
Jun 3, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented May 31, 2024

Implementing support for CSL builtins that modify DSDs:

@set_dsd_base_addr(input_dsd, base_addr)
@increment_dsd_offset(input_dsd, offset, elem_type)
@set_dsd_length(input_dsd, length)
@set_dsd_stride(input_dsd, stride)

Each of these ops only works with specific DSD types, which is handled in the verify_ method.

Added additional tests and support for tensor type as basis for mem dsds.

@n-io n-io requested review from AntonLydike and dk949 May 31, 2024 12:46
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (838c8ea) to head (cbb7419).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
+ Coverage   89.62%   89.64%   +0.02%     
==========================================
  Files         364      364              
  Lines       46658    46777     +119     
  Branches     7057     7090      +33     
==========================================
+ Hits        41816    41935     +119     
+ Misses       3748     3740       -8     
- Partials     1094     1102       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xdsl/dialects/csl.py Show resolved Hide resolved
xdsl/dialects/csl.py Outdated Show resolved Hide resolved
xdsl/dialects/csl.py Outdated Show resolved Hide resolved
xdsl/dialects/csl.py Outdated Show resolved Hide resolved
tests/filecheck/dialects/csl/ops.mlir Outdated Show resolved Hide resolved
tests/filecheck/dialects/csl/ops.mlir Outdated Show resolved Hide resolved
@n-io n-io requested a review from dk949 May 31, 2024 15:58
Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AntonLydike AntonLydike merged commit 6ef4760 into main Jun 3, 2024
10 checks passed
@AntonLydike AntonLydike deleted the nicolai/dsd-ops branch June 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants