-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialects: (csl) adding dsd ops #2674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
+ Coverage 89.62% 89.64% +0.02%
==========================================
Files 364 364
Lines 46658 46777 +119
Branches 7057 7090 +33
==========================================
+ Hits 41816 41935 +119
+ Misses 3748 3740 -8
- Partials 1094 1102 +8 ☔ View full report in Codecov by Sentry. |
dk949
requested changes
May 31, 2024
dk949
approved these changes
May 31, 2024
AntonLydike
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing support for CSL builtins that modify DSDs:
@set_dsd_base_addr(input_dsd, base_addr)
@increment_dsd_offset(input_dsd, offset, elem_type)
@set_dsd_length(input_dsd, length)
@set_dsd_stride(input_dsd, stride)
Each of these ops only works with specific DSD types, which is handled in the
verify_
method.Added additional tests and support for
tensor
type as basis for mem dsds.