core: Allowing overload of ClassVar from superclass #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
=======================================
Coverage 89.69% 89.70%
=======================================
Files 366 366
Lines 47049 47071 +22
Branches 7139 7140 +1
=======================================
+ Hits 42201 42223 +22
Misses 3745 3745
Partials 1103 1103 ☔ View full report in Codecov by Sentry. |
AntonLydike
reviewed
Jun 6, 2024
xdsl/irdl/irdl.py
Outdated
Comment on lines
1475
to
1482
| if field_name.isupper() and ( | ||
| get_origin(annotations[field_name]) is ClassVar | ||
| or ( | ||
| isinstance(annotations[field_name], str) | ||
| and annotations[field_name].startswith("ClassVar") | ||
| ) | ||
| ): | ||
| continue |
There was a problem hiding this comment.
Seeing as we have this in two places now, could we factor this out to make it easier to see that the two checks are identical? And maybe also make this code denser again?
There was a problem hiding this comment.
That sounds very reasonable, have factored out the check as suggested.
AntonLydike
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enhance PR #2687, which allowed uppercase
ClassVarfields on ops.This PR adds support for the case that an uppercase
ClassVaris defined (without a value) in a superclass and assigned a value in a subclass. This is confirmed by performing the same check as in the other PR.