Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (csl) print dsd ops #2694

Merged
merged 7 commits into from
Jun 7, 2024
Merged

dialects: (csl) print dsd ops #2694

merged 7 commits into from
Jun 7, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Jun 6, 2024

Enabling printing DSD ops to CSL.

@n-io n-io added the dialects Changes on the dialects label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (6095319) to head (c69cbb2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   89.74%   89.75%           
=======================================
  Files         367      367           
  Lines       47285    47324   +39     
  Branches     7191     7205   +14     
=======================================
+ Hits        42437    42476   +39     
  Misses       3745     3745           
  Partials     1103     1103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io requested review from dk949 and AntonLydike June 6, 2024 16:37
@n-io n-io marked this pull request as ready for review June 6, 2024 16:37
xdsl/backend/csl/print_csl.py Outdated Show resolved Hide resolved
xdsl/backend/csl/print_csl.py Outdated Show resolved Hide resolved
xdsl/dialects/csl.py Outdated Show resolved Hide resolved
xdsl/backend/csl/print_csl.py Outdated Show resolved Hide resolved
@dk949 dk949 added the backend Compiler backend in xDSL label Jun 6, 2024
@AntonLydike
Copy link
Collaborator

I feel like reducing the number of ops tested in printing would make this PR actually more readable. Maybe it is enough to test ~10-20 of the ops covered by case csl.BuiltinDsdOp(ops=ops):?

@n-io
Copy link
Collaborator Author

n-io commented Jun 7, 2024

I feel like reducing the number of ops tested in printing would make this PR actually more readable. Maybe it is enough to test ~10-20 of the ops covered by case csl.BuiltinDsdOp(ops=ops):?

Fair point, would it make sense to test the printing of one of each? If not, we can take out more.

@n-io n-io requested a review from dk949 June 7, 2024 12:39
Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work!

@n-io n-io merged commit e11fbe3 into main Jun 7, 2024
10 checks passed
@n-io n-io deleted the nicolai/print-dsd branch June 7, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants