-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (csl) print dsd ops #2694
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
=======================================
Coverage 89.74% 89.75%
=======================================
Files 367 367
Lines 47285 47324 +39
Branches 7191 7205 +14
=======================================
+ Hits 42437 42476 +39
Misses 3745 3745
Partials 1103 1103 ☔ View full report in Codecov by Sentry. |
I feel like reducing the number of ops tested in printing would make this PR actually more readable. Maybe it is enough to test ~10-20 of the ops covered by |
Fair point, would it make sense to test the printing of one of each? If not, we can take out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work!
Enabling printing DSD ops to CSL.