dialects: Add NoMemoryEffects to memref and snitch_runtime dialect ops

[AntonLydike]

This PR adds NoMemoryEffects trait to ops from the memref and snitch_runtime dialect that should have them.

[PapyChacal]

I have doubts regarding the snitch ones, but giving approval if given my comments it's still considered right, as I don't know the dialect's contract or semantics.

[AntonLydike]

@PapyChacal any idea what's wrong in the memref canonicalization test? It seems fishy to me.

[PapyChacal]

@PapyChacal any idea what's wrong in the memref canonicalization test? It seems fishy to me.

What sounds fishy to you? You rightfully marked memref.subview as having no side effect, so canonicalization will safely erase any unused subview 🙂

[AntonLydike]

@PapyChacal any idea what's wrong in the memref canonicalization test? It seems fishy to me.

What sounds fishy to you? You rightfully marked memref.subview as having no side effect, so canonicalization will safely erase any unused subview 🙂

I think your eyes deceive you:

I added a use to the memref, and so now we basically have:

func A(x: memref) {
 y = cast(cast(x))
 opaque_op(y)
}

And xdsl-opt -p canonicalize folds the two casts into one. But the filecheck expects there to be two casts!

[AntonLydike]

Ahh, I figured it out!

The memref canonicalization pass did not remove the old cast, it basically transformed the IR to:

func a(x: memref) {
y = old_cast(x)
y_new = new_cast(x)
 opaque_op(y_new)
}

and cse then righfully garbage collected the first cast!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (31cbdd2) to head (8b22eb0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2706   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         367      367           
  Lines       47401    47412   +11     
  Branches     7223     7223           
=======================================
+ Hits        42598    42608   +10     
  Misses       3694     3694           
- Partials     1109     1110    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.