dialects: (csl) Small incremental fixes to dialect structure (stacked PR) #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please also add type |
dk949
reviewed
Jun 12, 2024
Will be another PR |
AntonLydike
force-pushed
the
anton/csl-incremental-fixes
branch
from
ff61122 to
9d56377
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
=======================================
Coverage 89.86% 89.87%
=======================================
Files 367 367
Lines 47446 47442 -4
Branches 7230 7229 -1
=======================================
Hits 42638 42638
+ Misses 3697 3695 -2
+ Partials 1111 1109 -2 ☔ View full report in Codecov by Sentry. |
dk949
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@get_colortake an operand instead of property.ParamOptake a default value as operand instead of property.