dialects: (csl) set_tile_code fix traits #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set_tile_code` does not have to be a direct child of `layout`, e.g. it can
be used in a loop. But it does have to occur in a `layout`.
_NOTE_: the parameter to `set_tile_code` is specified as
`ComptimeStructType`, not `StructLike`. This is semantically correct
(though undocumented), i.e. you can't do this:
```zig
const my_params = @import_module("my_params.csl")
...
@set_tile_code(..., my_params);
```
Not that this is likely to happen.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 367 367
Lines 47442 47442
Branches 7228 7228
=======================================
Hits 42638 42638
Misses 3694 3694
Partials 1110 1110 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_tile_codedoes not have to be a direct child oflayout, e.g. it can be used in a loop. But it does have to occur in alayout.NOTE: the parameter to
set_tile_codeis specified asComptimeStructType, notStructLike. This is semantically correct (though undocumented), i.e. you can't do this: