dialects: (memref_stream) Add some more verification for generic op #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
PapyChacal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 367 367
Lines 47279 47298 +19
Branches 7219 7227 +8
=======================================
+ Hits 42523 42543 +20
Misses 3644 3644
+ Partials 1112 1111 -1 ☔ View full report in Codecov by Sentry. |
PapyChacal
reviewed
Jun 14, 2024
xdsl/dialects/memref_stream.py
Outdated
Comment on lines
544
to
547
| if m.data.num_symbols: | ||
| raise NotImplementedError( | ||
| f"Symbols currently not implemented in {self.name} indexing maps" | ||
| ) |
There was a problem hiding this comment.
I find this strange in a verifier; what is not implemented? The lowering?
PapyChacal
reviewed
Jun 14, 2024
xdsl/dialects/memref_stream.py
Outdated
Comment on lines
564
to
568
| if min_dims not in (len(iterator_types), num_parallel): | ||
| raise VerifyException( | ||
| "The number of dims in output indexing maps must be " | ||
| f"{len(iterator_types)} or {num_parallel}" | ||
| ) |
There was a problem hiding this comment.
This one bugs me too. I guess this is about special handling of reductions? Can you explain what it means to have len(iterator_types) dimensions in the output indexing map in the presence of reduction iterators?
|
I added a comment, and moved the not implemented error, does that make it clearer? |
PapyChacal
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't check as much as we could, this PR adds some more verification.