Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove deprecated methods that have been deprecated for a while #2729

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

superlopuh
Copy link
Member

No description provided.

@superlopuh superlopuh added the API Related to changes regarding API of constructs label Jun 14, 2024
@superlopuh superlopuh self-assigned this Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (361c70f) to head (8cab975).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
+ Coverage   89.86%   89.93%   +0.06%     
==========================================
  Files         367      367              
  Lines       47468    47279     -189     
  Branches     7234     7219      -15     
==========================================
- Hits        42659    42521     -138     
+ Misses       3697     3645      -52     
- Partials     1112     1113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big red number, big red ❤️!
Love to see it!

@superlopuh
Copy link
Member Author

Spooky, I don't see the same errors locally, I'll try again

@superlopuh superlopuh merged commit b61e65d into main Jun 14, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/deprecated-cleanup branch June 14, 2024 16:57
Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to note this deprecation in the next release, so that xdsl users are not surprised!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to changes regarding API of constructs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants