-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (builtin) Fix printing and parsing of UnitAttr
#2744
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b94458d
dialects: (builtin) Fix printing and parsing of `UnitAttr`
superlopuh 5e83ef9
make it a type instead
superlopuh c5b8c3e
Revert "make it a type instead"
superlopuh 853ed15
array of units
superlopuh 436cbde
comment
superlopuh 3e026a4
Merge branch 'main' into sasha/builtin/unit
superlopuh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -595,6 +595,7 @@ def _parse_optional_builtin_attr(self) -> Attribute | None: | |
return BytesAttr(bytes_lit) | ||
|
||
attrs = ( | ||
self.parse_optional_unit_attr, | ||
self.parse_optional_builtin_int_or_float_attr, | ||
self._parse_optional_array_attr, | ||
self._parse_optional_symref_attr, | ||
|
@@ -651,6 +652,22 @@ def _parse_strided_layout_attr(self, name: Span) -> Attribute: | |
self._parse_token(Token.Kind.GREATER, "Expected '>' in end of stride attribute") | ||
return StridedLayoutAttr(strides, None if offset == "?" else offset) | ||
|
||
def parse_optional_unit_attr(self) -> Attribute | None: | ||
""" | ||
Parse a value of `unit` type. | ||
unit-attribute ::= `unit` | ||
""" | ||
if self._current_token.kind != Token.Kind.BARE_IDENT: | ||
return None | ||
name = self._current_token.span.text | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. supernit: Not sure this extra variable assignment is needed here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. definitely not, although it doesn't really hurt either |
||
|
||
# Unit attribute | ||
if name == "unit": | ||
self._consume_token() | ||
return UnitAttr() | ||
|
||
return None | ||
|
||
def _parse_optional_builtin_parametrized_attr(self) -> Attribute | None: | ||
if self._current_token.kind != Token.Kind.BARE_IDENT: | ||
return None | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I suggest using the
test
dialect here? I don't think we want to depend onfunc
here...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree in general, although here it seemed like a good fit for consistency, happy to change it if you or anyone else insist