Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: fix yielding of values in memref_stream.generic lowering #2760

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

superlopuh
Copy link
Member

No description provided.

@superlopuh superlopuh added bug Something isn't working transformations Changes or adds a transformatio labels Jun 20, 2024
@superlopuh superlopuh self-assigned this Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (62f1851) to head (2fb3274).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2760   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files         372      372           
  Lines       47815    47816    +1     
  Branches     7330     7331    +1     
=======================================
+ Hits        42940    42941    +1     
  Misses       3737     3737           
  Partials     1138     1138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this fixes exactly, but what I see looks good!

Base automatically changed from sasha/memref_stream/indices-in-load to main June 21, 2024 08:47
@superlopuh superlopuh merged commit 12675f4 into main Jun 21, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/memref_stream/yields branch June 21, 2024 08:55
@superlopuh
Copy link
Member Author

The values yielded in the loop body were the results of the loop itself 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transformations Changes or adds a transformatio
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants