transformations: memref_streamify handle constant inits [3/3] #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm,
PapyChacal and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 89.79% 89.79%
=======================================
Files 381 381
Lines 48341 48341
Branches 7407 7408 +1
=======================================
Hits 43409 43409
Misses 3773 3773
Partials 1159 1159 ☔ View full report in Codecov by Sentry. |
…ttom-up-constants
…ref_stream/const-init
…m/const-init-lowering
…ref_stream/const-init-streamify
…m/const-init-lowering
…ref_stream/const-init-streamify
…ref_stream/const-init-streamify
…m/const-init-lowering
…ref_stream/const-init-streamify
…m/const-init-lowering
…ref_stream/const-init-streamify
…m/const-init-lowering
…ref_stream/const-init-streamify
AntonLydike
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR adding inits lowering support. With this, we can represent fully-streamed kernels with reduction iterators such as conv, pools, and matmul as a single
memref_stream.genericoperation.Note stacked PR.