dialects: (csl) Add csl.constants op and printing #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLydike
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2782 +/- ##
==========================================
+ Coverage 89.79% 89.80% +0.01%
==========================================
Files 379 381 +2
Lines 48124 48256 +132
Branches 7375 7382 +7
==========================================
+ Hits 43211 43336 +125
- Misses 3760 3767 +7
Partials 1153 1153 ☔ View full report in Codecov by Sentry. |
|
@dk949 do you want to review this as well? Otherwise I'll just merge! |
|
Sorry, completely missed it, can you give me 15min before merging? |
dk949
requested changes
Jun 26, 2024
|
@dk949 Fixed! |
dk949
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
csl.constantsop to define constant-initialized arrays and printing for said operation.