Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv, x86) do not print empty <> for unallocated registers #2786

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented Jun 26, 2024

I think this removes quite a bit of noise when reading the IR.

Note that the code changes are the three bottom files at the bottom of the files view, the rest is filecheck changes.

@superlopuh superlopuh added the dialects Changes on the dialects label Jun 26, 2024
@superlopuh superlopuh self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (17ec8ba) to head (4853f11).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2786      +/-   ##
==========================================
- Coverage   89.78%   89.78%   -0.01%     
==========================================
  Files         382      382              
  Lines       48412    48413       +1     
  Branches     7427     7426       -1     
==========================================
- Hits        43469    43468       -1     
- Misses       3780     3781       +1     
- Partials     1163     1164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, this does look much cleaner.

@superlopuh superlopuh merged commit f8834ad into main Jun 27, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/riscv/no-angle-brackets branch June 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants