Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv) Make riscv.get_register pure #2797

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

AntonLydike
Copy link
Collaborator

This makes get_register pure, as it should be.

The op never reads/writes and is safe to DCE and CSE.

@AntonLydike AntonLydike added the dialects Changes on the dialects label Jun 27, 2024
@AntonLydike AntonLydike requested a review from superlopuh June 27, 2024 22:04
@AntonLydike AntonLydike self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (772df11) to head (613238c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
- Coverage   89.79%   89.79%   -0.01%     
==========================================
  Files         387      387              
  Lines       48507    48507              
  Branches     7434     7434              
==========================================
- Hits        43559    43557       -2     
- Misses       3780     3782       +2     
  Partials     1168     1168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntonLydike AntonLydike merged commit 85f5050 into main Jun 27, 2024
10 checks passed
@AntonLydike AntonLydike deleted the anton/riscv-pure-get-reg-op branch June 27, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants