Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (memref_stream) make bounds in dialect index typed not IntAttr #2810

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

superlopuh
Copy link
Member

I really should not have been lazy and done this from the start. It makes sense from a semantic point of view, since these are converted to loop bounds, which are index-valued already.

Note stacked PR

@superlopuh superlopuh added the dialects Changes on the dialects label Jul 1, 2024
@superlopuh superlopuh self-assigned this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (02c9118) to head (185a889).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           sasha/riscv/unpeel-matmul    #2810      +/-   ##
=============================================================
- Coverage                      89.81%   89.80%   -0.02%     
=============================================================
  Files                            396      396              
  Lines                          49010    48844     -166     
  Branches                        7503     7482      -21     
=============================================================
- Hits                           44020    43865     -155     
+ Misses                          3802     3796       -6     
+ Partials                        1188     1183       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from sasha/riscv/unpeel-matmul to main July 1, 2024 21:42
@superlopuh superlopuh merged commit 93e6b07 into main Jul 1, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/memref_stream/index-bounds branch July 1, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants