core: Add option to clone name hints #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
AntonLydike,
martin-luecke,
georgebisbas,
math-fehr,
PapyChacal and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 396 396
Lines 49096 49139 +43
Branches 7519 7533 +14
=======================================
+ Hits 44104 44143 +39
- Misses 3803 3805 +2
- Partials 1189 1191 +2 ☔ View full report in Codecov by Sentry. |
PapyChacal
approved these changes
Jul 2, 2024
math-fehr
approved these changes
Jul 3, 2024
PapyChacal
approved these changes
Jul 3, 2024
AntonLydike
approved these changes
Jul 3, 2024
webmiche
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Did I every mention that I hate SSAValues in the CHECK lines? 😅
There was a problem hiding this comment.
I added --xdsl-anonymize to filecheckize for this purpose exactly, it only anonymizes %digit, not %identifier :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for this setting is True