transformations: add memref-stream-interleave #2823
Conversation
superlopuh
requested review from
nazavode,
compor,
zero9178,
AntonLydike and
JosseVanDelm
superlopuh
changed the base branch from
main
to
sasha/memref_stream/newline-syntax
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
==========================================
- Coverage 89.83% 89.83% -0.01%
==========================================
Files 396 397 +1
Lines 49139 49194 +55
Branches 7533 7549 +16
==========================================
+ Hits 44143 44191 +48
- Misses 3805 3808 +3
- Partials 1191 1195 +4 ☔ View full report in Codecov by Sentry. |
| + tuple( | ||
| AffineExpr.dimension(i) | ||
| for i in range( | ||
| interleave_bound_index + 1, m.data.num_dims + 2 |
There was a problem hiding this comment.
Where do these numbers stem from?
There was a problem hiding this comment.
The idea is that there is an extra dimension added somewhere in the middle of the affine map domain. This is the slice of the domain after the updated value, so it's going from inserted_index + 1 to old_len + 1 inclusive.
…eaved' into sasha/memref_stream/lower-interleaved
|
I just realized a design flaw in this representation while implementing the lowering to loops, I'll try to finish an end-to-end lowering and see whether this is still the right approach. |
|
Lowering works OK, let's merge this and keep going. |
No description provided.