dialects: (memref) add custom syntax for memref_subview #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
zero9178,
AntonLydike,
georgebisbas and
PapyChacal
superlopuh
commented
Jul 4, 2024
superlopuh
commented
Jul 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
=======================================
Coverage 89.88% 89.89%
=======================================
Files 398 398
Lines 49609 49656 +47
Branches 7623 7630 +7
=======================================
+ Hits 44590 44636 +46
Misses 3824 3824
- Partials 1195 1196 +1 ☔ View full report in Codecov by Sentry. |
webmiche
reviewed
Jul 5, 2024
| @@ -591,6 +595,9 @@ def get_canonicalization_patterns(cls) -> tuple[RewritePattern, ...]: | |||
|
|
|||
| @irdl_op_definition | |||
| class Subview(IRDLOperation): | |||
|
|
|||
| DYNAMIC_INDEX: ClassVar[int] = -9223372036854775808 | |||
PapyChacal
approved these changes
Jul 5, 2024
|
So I initially did it without the space, and then added it back in to be 1:1 conformant with MLIR syntax. |
superlopuh
commented
Jul 5, 2024
Comment on lines
+51
to
+52
| // CHECK-NEXT: %{{.*}} = memref.subview %{{.*}}[0, 0] [1, 3] [1, 1] : memref<10x3xi32> to memref<3xi32> | ||
| // CHECK-NEXT: %{{.*}} = memref.subview %{{.*}}[%{{.*}}, 0] [1, 3] [1, 1] : memref<10x3xi32> to memref<3xi32, strided<[1], offset: ?>> |
There was a problem hiding this comment.
@PapyChacal, this is the output from MLIR. It looks like the doc online disagrees, but I'd rather go with the MLIR we have as source of truth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to match MLIR exactly in the syntax, and found a bug in the stencil lowering, which lowers to an invalid memref subview. My understanding is that the subview must be a subview, and so negative offsets are not allowed.
I won't merge without someone from the stencil side of things approving the PR, but also I'd love to use this for the linalg to snitch project, so I'm hoping that we can resolve this soonish.