transformations: Fix subview hack in stencil conversion #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2843 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 398 398
Lines 49607 49609 +2
Branches 7621 7623 +2
=======================================
+ Hits 44590 44592 +2
Misses 3823 3823
Partials 1194 1194 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Jul 5, 2024
|
I faintly remember this being relevant in the DMP to MPI lowering or something. Do you know how this interacts with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly allocate buffers with the expected layout instead.
Reminder: This is a shallow layout, simply used to offset indices used in accesses, not modifying any physical layout. This avoids the need to propagate more information to
stencil.access, which can simply access the lowered memref using its own coordinate system.