transformations: Handle affine.apply in lower-affine #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
zero9178,
AntonLydike,
math-fehr and
PapyChacal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2849 +/- ##
==========================================
- Coverage 89.87% 89.87% -0.01%
==========================================
Files 399 399
Lines 49776 49822 +46
Branches 7662 7671 +9
==========================================
+ Hits 44737 44778 +41
- Misses 3834 3836 +2
- Partials 1205 1208 +3 ☔ View full report in Codecov by Sentry. |
zero9178
reviewed
Jul 5, 2024
Comment on lines
52
to
53
| // CHECK-NEXT: %apply_res_1 = arith.muli %apply_dim, %apply_res : index | ||
| // CHECK-NEXT: %apply_res_2 = arith.addi %apply_sym, %apply_res_1 : index |
There was a problem hiding this comment.
This seems to be a bug. apply_dim and apply_sym should be switched since s0 binds to apply_sym and d0 to apply_dim.
There was a problem hiding this comment.
nice catch! I'll take a look
zero9178
approved these changes
Jul 6, 2024
Co-authored-by: Markus Böck <markus.boeck02@gmail.com>
Co-authored-by: Markus Böck <markus.boeck02@gmail.com>
|
I agree completely, I think the key here might be name hints, I'll look into it a bit more in subsequent PRs |
superlopuh
force-pushed
the
sasha/affine/apply-custom-syntax
branch
from
5b7cc5c to
5a18a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this in the generic to loops lowering when not all the arguments are streamed