dialects: (memref_stream) remove unused operands in canonicalization #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaved' into sasha/memref_stream/lower-interleaved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
=======================================
Coverage ? 89.86%
=======================================
Files ? 396
Lines ? 49796
Branches ? 7679
=======================================
Hits ? 44749
Misses ? 3837
Partials ? 1210 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Markus Böck <markus.boeck02@gmail.com>
Co-authored-by: Markus Böck <markus.boeck02@gmail.com>
…m/unused-operands
…eam/unused-operands
…eam/unused-operands
AntonLydike
approved these changes
Jul 8, 2024
| // CHECK-NEXT: ], | ||
| // CHECK-NEXT: iterator_types = ["parallel", "parallel", "reduction"] | ||
| // CHECK-NEXT: } ins(%{{.*}} : memref<4x2xf64>) outs(%{{.*}}, %{{.*}} : memref<4x3xf64>, memref<4x3xf64>) inits(%H : f64, None) { | ||
| // CHECK-NEXT: ^{{.*}}(%{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64): |
There was a problem hiding this comment.
Suggested change
| // CHECK-NEXT: ^{{.*}}(%{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64): | |
| // CHECK-NEXT: ^{{\S*}}(%{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64): |
Otherwise this will still pass for blocks with 15 arguments.
| // CHECK-NEXT: ], | ||
| // CHECK-NEXT: iterator_types = ["parallel", "parallel", "reduction", "interleaved"] | ||
| // CHECK-NEXT: } ins(%{{.*}}, %{{.*}} : memref<3x5xf64>, memref<5x8xf64>) outs(%{{.*}} : memref<3x8xf64>) { | ||
| // CHECK-NEXT: ^{{.*}}(%{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64): |
There was a problem hiding this comment.
Suggested change
| // CHECK-NEXT: ^{{.*}}(%{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64, %{{.*}} : f64): | |
| // CHECK-NEXT: ^{{\S*}}(%{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64, %{{\S*}} : f64): |
| num_outputs_dropped = 0 | ||
| for index, arg in enumerate(block_args[:num_inputs]): | ||
| drop_operand = index in unused_input_indices | ||
| is_input = index < num_inputs |
There was a problem hiding this comment.
Isn't this always the case, as you are only iterating over the first num_inputs block args?
There was a problem hiding this comment.
indeed, this is from a previous version of the code, I'll remove it
- remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens in pooling, where a tensor with a shape and no contents is created to specify the iteration space.