dialects: (linalg) Fix matmul custom syntax and custom init

[qaco]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@105cc1e). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2852   +/-   ##
=======================================
  Coverage        ?   89.89%           
=======================================
  Files           ?      398           
  Lines           ?    49642           
  Branches        ?     7636           
=======================================
  Hits            ?    44624           
  Misses          ?     3822           
  Partials        ?     1196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[superlopuh]

Thank you for opening this PR! Let's take some time to address some things that would be good to have, such as filecheck tests for the updated assembly format (we usually have two for dialects that are mirrored from MLIR, one for xdsl parsing and printing, and one for mlir compatibility), and also for the init fix (these are usually in pytest).

The text of the PR would also be good to delete, once all the points have been addressed.

[superlopuh]

Oh and I would recommend setting up the precommit hooks with make precommit-install

[qaco]

Thank you for opening this PR! Let's take some time to address some things that would be good to have, such as filecheck tests for the updated assembly format (we usually have two for dialects that are mirrored from MLIR, one for xdsl parsing and printing, and one for mlir compatibility), and also for the init fix (these are usually in pytest).

The text of the PR would also be good to delete, once all the points have been addressed.

Thank you for your advices. I have added the suggested tests.

[superlopuh]

LGTM!