Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: (toy) remove all custom instructions from Toy #2863

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

superlopuh
Copy link
Member

I added a bunch of hacks to Toy to get it to work, but we now have all the functionality we need to remove the custom behaviour.

@superlopuh superlopuh added the documentation Improvements or additions to documentation label Jul 8, 2024
@superlopuh superlopuh requested a review from AntonLydike July 8, 2024 08:23
@superlopuh superlopuh self-assigned this Jul 8, 2024
Base automatically changed from sasha/riscv/lower-dealloc to main July 8, 2024 08:24
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (e5f0039) to head (51630e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
- Coverage   89.87%   89.85%   -0.02%     
==========================================
  Files         399      395       -4     
  Lines       49726    49633      -93     
  Branches     7655     7650       -5     
==========================================
- Hits        44690    44598      -92     
+ Misses       3832     3831       -1     
  Partials     1204     1204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Red 💯 📉

@superlopuh superlopuh merged commit 620d7fb into main Jul 8, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/toy/remove-syscalls branch July 8, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants