Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ship cmath.irdl file in pypi #2905

Merged
merged 4 commits into from
Jul 19, 2024
Merged

bug: ship cmath.irdl file in pypi #2905

merged 4 commits into from
Jul 19, 2024

Conversation

superlopuh
Copy link
Member

For some reason I couldn't test this locally, when I install into a different folder with a relative path, the old cmath.py file is also included for some spooky reason...

@superlopuh superlopuh added the bug Something isn't working label Jul 19, 2024
@superlopuh superlopuh self-assigned this Jul 19, 2024
@superlopuh
Copy link
Member Author

~/Developer/_superlopuh/Python/temp ❯ pip install git+https://github.com/xdslproject/xdsl.git@279b55e0e351f0a7c4f802388376b7e37be37b1d
~/Developer/_superlopuh/Python/temp ❯ find . -name "*cmath*"                                            6s Py temp 14:41:27
./venv/lib/python3.12/site-packages/xdsl/dialects/cmath.irdl

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (ed144cf) to head (279b55e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2905   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         403      403           
  Lines       50422    50422           
  Branches     7787     7787           
=======================================
+ Hits        45331    45333    +2     
+ Misses       3863     3862    -1     
+ Partials     1228     1227    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math-fehr math-fehr merged commit f61f060 into main Jul 19, 2024
9 checks passed
@math-fehr math-fehr deleted the sasha/misc/ship-cmath branch July 19, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants