Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix default builtin type definitions #2907

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jorendumoulin
Copy link
Collaborator

I'm guessing this was a typo

@jorendumoulin jorendumoulin requested a review from superlopuh July 19, 2024 14:20
@jorendumoulin jorendumoulin self-assigned this Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (2f24609) to head (3243c4d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   89.90%   89.90%   -0.01%     
==========================================
  Files         403      403              
  Lines       50422    50422              
  Branches     7787     7787              
==========================================
- Hits        45333    45331       -2     
- Misses       3862     3863       +1     
- Partials     1227     1228       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh oh

@jorendumoulin jorendumoulin merged commit c350e03 into main Jul 19, 2024
10 checks passed
@jorendumoulin jorendumoulin deleted the joren/fix-builtin-types branch July 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants