-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: add convert-arith-to-riscv-snitch pass #2914
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
==========================================
- Coverage 89.90% 89.90% -0.01%
==========================================
Files 403 404 +1
Lines 50424 50478 +54
Branches 7788 7797 +9
==========================================
+ Hits 45334 45380 +46
- Misses 3862 3866 +4
- Partials 1228 1232 +4 ☔ View full report in Codecov by Sentry. |
// CHECK: builtin.module | ||
// CHECK-NEXT: %l, %r = "test.op"() : () -> (!riscv.freg, !riscv.freg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// CHECK: builtin.module | |
// CHECK-NEXT: %l, %r = "test.op"() : () -> (!riscv.freg, !riscv.freg) | |
// CHECK: builtin.module | |
// CHECK-NEXT: %[[L.*]], %[[R:.*]] = "test.op"() : () -> (!riscv.freg, !riscv.freg) |
Since 9b43500 landed, does this mean we can use named SSA variables now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do it in this case if the variable names are stable and more readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge for now since you've approved but happy to refactor tests together tomorrow, there's more to come
Lets us handle the packed SIMD operations.