Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: add convert-arith-to-riscv-snitch pass #2914

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

superlopuh
Copy link
Member

Lets us handle the packed SIMD operations.

@superlopuh superlopuh added the transformations Changes or adds a transformatio label Jul 21, 2024
@superlopuh superlopuh self-assigned this Jul 21, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (e863366) to head (d48500f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   89.90%   89.90%   -0.01%     
==========================================
  Files         403      404       +1     
  Lines       50424    50478      +54     
  Branches     7788     7797       +9     
==========================================
+ Hits        45334    45380      +46     
- Misses       3862     3866       +4     
- Partials     1228     1232       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +3 to +4
// CHECK: builtin.module
// CHECK-NEXT: %l, %r = "test.op"() : () -> (!riscv.freg, !riscv.freg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// CHECK: builtin.module
// CHECK-NEXT: %l, %r = "test.op"() : () -> (!riscv.freg, !riscv.freg)
// CHECK: builtin.module
// CHECK-NEXT: %[[L.*]], %[[R:.*]] = "test.op"() : () -> (!riscv.freg, !riscv.freg)

Since 9b43500 landed, does this mean we can use named SSA variables now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do it in this case if the variable names are stable and more readable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge for now since you've approved but happy to refactor tests together tomorrow, there's more to come

Base automatically changed from sasha/memref_stream/ssum-fastmath to main July 21, 2024 17:39
@superlopuh superlopuh merged commit 123cbbc into main Jul 21, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/memref_stream/ssum-lower-vector branch July 21, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants