transformations: use block argument types when streamifying #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Federico Ficarelli <1379149+nazavode@users.noreply.github.com>
superlopuh
force-pushed
the
sasha/memref_stream/ssum-streamify-vectors
branch
from
879dedb to
f22f1f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sasha/memref_stream/ssum-test-raise #2920 +/- ##
=======================================================================
- Coverage 89.89% 89.89% -0.01%
=======================================================================
Files 404 404
Lines 50501 50500 -1
Branches 7802 7802
=======================================================================
- Hits 45400 45397 -3
- Misses 3868 3869 +1
- Partials 1233 1234 +1 ☔ View full report in Codecov by Sentry. |
zero9178
approved these changes
Jul 22, 2024
xdsl/transforms/memref_streamify.py
Outdated
| for index, value in enumerate(op.inputs) | ||
| if isinstance(value_type := value.type, memref.MemRefType) | ||
| and op.body.block.args[index].uses | ||
| (index, op.body.block.args[index].type) |
There was a problem hiding this comment.
Suggested change
| (index, op.body.block.args[index].type) | |
| (index, arg.type) |
(if my Python is not incorrect)
…emref_stream/ssum-test-raise
…stream/ssum-streamify-vectors
nazavode
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.