Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (snitch_stream) add repetition to stride pattern #2927

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

superlopuh
Copy link
Member

Without the repeat setting when the last offset is 0, Snitch just fetches every time without caching the value, repeat avoids this.

CC @jorendumoulin @JosseVanDelm seems like more and more accelerator config! One of the things that's somewhat annoying is that we now have to defensively reset the repetition count, it would be great to avoid this eventually.

@superlopuh superlopuh added the dialects Changes on the dialects label Jul 22, 2024
@superlopuh superlopuh self-assigned this Jul 22, 2024
@JosseVanDelm
Copy link
Collaborator

JosseVanDelm commented Jul 22, 2024

@superlopuh this is exactly what accfg is useful for indeed!!! @AntonLydike also recently added a accfg.reset op that should be useful to reset required at the end of MLIRs scope.
Upstreaming accfg is going to take a while though in these holiday-filled (yay) days :(

Copy link
Collaborator

@nazavode nazavode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

Base automatically changed from sasha/snitch_stream/ssr-comments to main July 22, 2024 22:26
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (cc704e0) to head (8df3d31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2927   +/-   ##
=======================================
  Coverage   89.90%   89.91%           
=======================================
  Files         405      405           
  Lines       50562    50574   +12     
  Branches     7818     7820    +2     
=======================================
+ Hits        45458    45473   +15     
+ Misses       3869     3867    -2     
+ Partials     1235     1234    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 024068c into main Jul 22, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/snitch_stream/stride-pattern-repeat branch July 22, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants