dialects: (memref_stream) add doc and library call support #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
+ Coverage 89.91% 89.92% +0.01%
==========================================
Files 405 405
Lines 50594 50602 +8
Branches 7822 7824 +2
==========================================
+ Hits 45490 45504 +14
+ Misses 3870 3865 -5
+ Partials 1234 1233 -1 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Jul 23, 2024
superlopuh
reviewed
Jul 23, 2024
jorendumoulin
force-pushed
the
joren/memref-stream-library-call
branch
from
b56d913 to
9a38bd5
Compare
superlopuh
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the
library_callattribute to designate to which accelerator we want to dispatch a certain linalg generic to. Right now, this information gets lost when converting from linalg.generic to memref_stream.generic, which is somewhat annoying. This PR adds support for these generic attributes in the memref stream dialect.