Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (tensor) Incorrect default 'dynamic index' on insert_slice op #2974

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Aug 1, 2024

If the tensor.insert_slice op is set up with dynamic index, the default value should be DYNAMIC_INDEX.

This is required by mlir upstream. The default values in the static get method are currently set incorrectly.

@n-io n-io requested a review from PapyChacal August 1, 2024 14:59
@n-io n-io self-assigned this Aug 1, 2024
@n-io n-io added dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable labels Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (3543d82) to head (8ea5891).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2974   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         409      409           
  Lines       51085    51108   +23     
  Branches     7923     7925    +2     
=======================================
+ Hits        45905    45928   +23     
+ Misses       3926     3925    -1     
- Partials     1254     1255    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io merged commit 258dda0 into main Aug 1, 2024
10 checks passed
@n-io n-io deleted the nicolai/fix-dynamic-tensor-slice-ops branch August 1, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants