dialects: Add stencil features meant for bufferization #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 421287a Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Mon Aug 5 10:23:04 2024 +0100 It's okay pyright commit 581ae9b Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Mon Aug 5 10:09:26 2024 +0100 Remove superfluous test. commit a745623 Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Mon Aug 5 10:05:17 2024 +0100 filecheck readability. commit e78f970 Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Fri Aug 2 14:53:02 2024 +0100 \o/ commit 5695079 Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Thu Jun 27 15:28:52 2024 +0100 More stuff commit db70f4d Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Wed Jul 31 11:58:06 2024 +0100 stencil.apply bufferization. commit e776933 Author: Emilien Bauer <bauer.emilien@gmail.com> Date: Wed Jun 26 18:06:33 2024 +0100 Implement bufferized stencil conversion.
PapyChacal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## emilien/stencil-bufferized #2985 +/- ##
==============================================================
- Coverage 89.85% 89.84% -0.02%
==============================================================
Files 409 409
Lines 51217 51252 +35
Branches 7951 7956 +5
==============================================================
+ Hits 46023 46046 +23
- Misses 3931 3943 +12
Partials 1263 1263 ☔ View full report in Codecov by Sentry. |
PapyChacal
commented
Aug 5, 2024
Comment on lines
+14
to
+19
| class AllocUnused(RewritePattern): | ||
|
|
||
| @op_type_rewrite_pattern | ||
| def match_and_rewrite(self, op: stencil.AllocOp, rewriter: PatternRewriter) -> None: | ||
| if not op.field.uses: | ||
| rewriter.erase_op(op) |
There was a problem hiding this comment.
This would be best done through usual DCE with an implementation of side-effect values; but I felt like moving to the application for now.
georgebisbas
approved these changes
Aug 5, 2024
n-io
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from: