Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv_snitch) add vfmax.s #2988

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented Aug 7, 2024

Useful for relu

@superlopuh superlopuh added the dialects Changes on the dialects label Aug 7, 2024
@superlopuh superlopuh requested a review from nazavode August 7, 2024 12:13
@superlopuh superlopuh self-assigned this Aug 7, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small refactor, all the result names are now independent of the order so we can move them around, and each of the register operands and results is different so the test keeps track of the order these are printed in.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (04bdfc0) to head (a127953).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2988      +/-   ##
==========================================
- Coverage   89.83%   89.83%   -0.01%     
==========================================
  Files         411      411              
  Lines       51570    51566       -4     
  Branches     8014     8015       +1     
==========================================
- Hits        46327    46323       -4     
  Misses       3963     3963              
  Partials     1280     1280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 4933ebc into main Aug 7, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/riscv_snitch/vfmax branch August 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants