-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Add Dialect.split_name
method
#3003
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
- Coverage 89.84% 89.83% -0.02%
==========================================
Files 411 411
Lines 51618 51698 +80
Branches 8021 8036 +15
==========================================
+ Hits 46378 46442 +64
- Misses 3961 3970 +9
- Partials 1279 1286 +7 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we've added an error, it would be good to add a pytest that tracks the error message. The more I think of it, the more it seems that raising ValueError
instead of asserting would be a little cleaner. Sorry about the churn. There are a bunch of examples in the tests of how to catch errors and test for contents.
Adds a
Dialect.split_name
method as discussed in #3002