Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add Dialect.split_name method #3003

Merged
merged 6 commits into from
Aug 12, 2024
Merged

misc: Add Dialect.split_name method #3003

merged 6 commits into from
Aug 12, 2024

Conversation

alexarice
Copy link
Collaborator

Adds a Dialect.split_name method as discussed in #3002

@alexarice alexarice added minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous labels Aug 9, 2024
@alexarice alexarice requested a review from superlopuh August 9, 2024 15:59
@alexarice alexarice self-assigned this Aug 9, 2024
@alexarice alexarice added the testing PRs that modify tests label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (6b0a371) to head (aa10a09).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
- Coverage   89.84%   89.83%   -0.02%     
==========================================
  Files         411      411              
  Lines       51618    51698      +80     
  Branches     8021     8036      +15     
==========================================
+ Hits        46378    46442      +64     
- Misses       3961     3970       +9     
- Partials     1279     1286       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xdsl/ir/core.py Outdated Show resolved Hide resolved
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
xdsl/ir/core.py Outdated Show resolved Hide resolved
alexarice and others added 2 commits August 10, 2024 13:16
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've added an error, it would be good to add a pytest that tracks the error message. The more I think of it, the more it seems that raising ValueError instead of asserting would be a little cleaner. Sorry about the churn. There are a bunch of examples in the tests of how to catch errors and test for contents.

@alexarice alexarice merged commit 1f000a1 into main Aug 12, 2024
10 checks passed
@alexarice alexarice deleted the alexarice/split_name branch August 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants