transformations: update stencil lowering to properly accomodate bufferized stencils. #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es on stencil ops.
This significantly lift analysis difficulty on the whole apply/load/store; might be slightly less generic? For now, it's a step forward.
PapyChacal
force-pushed
the
emilien/stencil-bufferized-lowering
branch
from
a28e38b to
0607a22
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3016 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 416 416
Lines 52427 52450 +23
Branches 8110 8117 +7
=======================================
+ Hits 47124 47145 +21
- Misses 3999 4001 +2
Partials 1304 1304 ☔ View full report in Codecov by Sentry. |
PapyChacal
force-pushed
the
emilien/stencil-bufferized-lowering
branch
from
0607a22 to
7b4e981
Compare
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
PapyChacal
changed the title
superlopuh
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stencil.allocstencil.apply(Those subviews areload/store's jobs on value-semantics, so just golfing for minimal changes while keeping one pass, for now!)