Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Implement simple helpers for construct type access. #3024

Merged
merged 7 commits into from
Aug 13, 2024
Merged

core: Implement simple helpers for construct type access. #3024

merged 7 commits into from
Aug 13, 2024

Conversation

PapyChacal
Copy link
Collaborator

Just provide result_types and operands_types on Operation and args_types on Block to get rid of a lot of (IMO) annoying comprehensions.

IRDLOperation hopefully following!

@PapyChacal PapyChacal added the core xDSL core (ir, textual format, ...) label Aug 13, 2024
@PapyChacal PapyChacal requested a review from superlopuh August 13, 2024 12:13
@PapyChacal PapyChacal self-assigned this Aug 13, 2024
@PapyChacal PapyChacal marked this pull request as ready for review August 13, 2024 12:20
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (6d27775) to head (2803f38).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3024   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         412      412           
  Lines       51816    51823    +7     
  Branches     8064     8033   -31     
=======================================
+ Hits        46558    46565    +7     
  Misses       3967     3967           
  Partials     1291     1291

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

superlopuh
superlopuh reviewed Aug 13, 2024
View reviewed changes
xdsl/dialects/fsm.py Outdated Show resolved Hide resolved
superlopuh
superlopuh reviewed Aug 13, 2024
View reviewed changes
xdsl/dialects/gpu.py Outdated Show resolved Hide resolved
superlopuh
superlopuh reviewed Aug 13, 2024
View reviewed changes
xdsl/ir/core.py Outdated Show resolved Hide resolved
PapyChacal and others added 4 commits August 13, 2024 13:34
@PapyChacal @superlopuh
Update xdsl/dialects/fsm.py
fb61fbb 
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@PapyChacal @superlopuh
Update xdsl/dialects/gpu.py
481c893 
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@PapyChacal
Consistent naming.
01fb228
@PapyChacal
Merge branch 'main' into emilien/types-helpers
f875ac1
superlopuh
superlopuh approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement indeed

@PapyChacal PapyChacal mentioned this pull request Aug 13, 2024
Merged
@PapyChacal PapyChacal merged commit b04032f into main Aug 13, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/types-helpers branch August 13, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superlopuh superlopuh superlopuh approved these changes

Assignees

@PapyChacal PapyChacal

Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PapyChacal @superlopuh